[webkit-reviews] review denied: [Bug 41228] Fix http/tests/local/blob/send-data-blob.html on Windows : [Attachment 59943] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 41228: Fix http/tests/local/blob/send-data-blob.html on Windows
https://bugs.webkit.org/show_bug.cgi?id=41228

Attachment 59943: Patch
https://bugs.webkit.org/attachment.cgi?id=59943&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
WebCore/platform/BlobItem.cpp:128
 +  // Convert line-endings (CR and LF) into CRLF.
Probably better to say:
  // Normalize all line-endings to CRLF.

WebCore/platform/BlobItem.cpp:176
 +  static CString convertToCR(const CString& from)
I think we can combine convertToCR and convertToLF to one single function like
the following:
  convertToCROrLF(const CString& from, bool toCR)
  {
      char fromLineEndingChar = toCR ? '\n' : '\r';
      char toLineEndingChar = toCR ? '\r' : '\n';
      ...
      while (...) {
	  ...
	  } else if (c == fromLineEndingChar) {
	      // Turn CF/LF into LF/CR.
  }