[webkit-reviews] review denied: [Bug 40380] [Qt] When a layer is really opaque (ie has a background color that has 255 alpha) we should fill the layer with that color to tell Qt that the pixemap has no alpha. : [Attachment 59933] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40380: [Qt] When a layer is really opaque (ie has a background color that
has 255 alpha) we should fill the layer with that color to tell Qt that the
pixemap has no alpha.
https://bugs.webkit.org/show_bug.cgi?id=40380

Attachment 59933: Patch
https://bugs.webkit.org/attachment.cgi?id=59933&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +    if (rendererHasBackground()) {
> +	   const Color &bgColor = rendererBackgroundColor();
> +	   m_graphicsLayer->setBackgroundColor(bgColor);
> +    } else
> +	   m_graphicsLayer->clearBackgroundColor();

You can't do this. GraphicsLayers are not always the same size as their
elements; in many cases, they are larger (e.g. try one with a box-shadow, or a
abs. pos. child).