[webkit-reviews] review granted: [Bug 41281] HTML5 Regression: Crash in insert() : [Attachment 59907] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41281: HTML5 Regression: Crash in insert()
https://bugs.webkit.org/show_bug.cgi?id=41281

Attachment 59907: Patch
https://bugs.webkit.org/attachment.cgi?id=59907&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I definitely like this change.

WebCore/html/HTMLDocumentParser.h:112
 +	bool shouldDelayEnd() const { return inWrite() || isWaitingForScripts()
|| inScriptExecution() || isScheduledForResume(); }
Seems sightly silly to put this in the header.	Generally the .cpp is
better/cleaner.

I was sad when I broke write into insert and append because the code sharing
previously seemed good.  It's still good.  But I wonder how it could be better.