[webkit-reviews] review requested: [Bug 41292] [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in browser, if the call is initiated by user, allow the popup : [Attachment 59922] patch v1 to set right value on UserGestureIndicator to indicate whether the NPN_Evaluate allows popup window or not.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 28 12:19:38 PDT 2010
Johnny Ding <jnd at chromium.org> has asked for review:
Bug 41292: [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in
browser, if the call is initiated by user, allow the popup
https://bugs.webkit.org/show_bug.cgi?id=41292
Attachment 59922: patch v1 to set right value on UserGestureIndicator to
indicate whether the NPN_Evaluate allows popup window or not.
https://bugs.webkit.org/attachment.cgi?id=59922&action=review
------- Additional Comments from Johnny Ding <jnd at chromium.org>
I didn't add layout test on this change. Will think about the test when I
figure out why Chroimum Mac is OK for youtube case without this change.
More information about the webkit-reviews
mailing list