[webkit-reviews] review requested: [Bug 41284] ApplyStyleCommand::splitTextElementAtEndIfNeeded/splitTextAtEndIfNeeded ASSERTS should be returns. : [Attachment 59909] Patch

[bugzilla-daemon at webkit.org]

Mike Fenton <mifenton at rim.com> has asked  for review:
Bug 41284:
ApplyStyleCommand::splitTextElementAtEndIfNeeded/splitTextAtEndIfNeeded ASSERTS
should be returns.
https://bugs.webkit.org/show_bug.cgi?id=41284

Attachment 59909: Patch
https://bugs.webkit.org/attachment.cgi?id=59909&action=review

------- Additional Comments from Mike Fenton <mifenton at rim.com>
Both splitTextElementAtStartIfNeeded and splitTextAtEndIfNeeded call
splitTextNodeContainingElement and splitTextNode respectively assuming that the
split will succeed and verify the resulting using ASSERTS.

In both functions there are a number of early returns possibly.  The state
after the split occurs should be validated with an if statement so that a
proper return can happen.