[webkit-reviews] review denied: [Bug 40932] Separate line-ending conversion code from BlobItem for code cleanup : [Attachment 59273] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 40932: Separate line-ending conversion code from BlobItem for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=40932

Attachment 59273: Patch
https://bugs.webkit.org/attachment.cgi?id=59273&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
WebCore/platform/text/LineEnding.cpp:2
 +   * Copyright (C) 2010 Google Inc. All rights reserved.
Please check the author of the original function and give credit here too.

WebCore/platform/text/LineEnding.h:53
 +  // Convert WebCore::String to CString with given line-ending and encoding.
This comment is a little bit vague. It does not mention what is fixed regarding
the line ending. Could you please add more detailed comment here?
Also mentioning "Convert WebCore::String to CString" seems to be unnecessary
since the argument type and return type indicate that clearly.