[webkit-reviews] review denied: [Bug 41243] [chromium] Add support for WebGL to the accelerated compositor : [Attachment 59841] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 41243: [chromium] Add support for WebGL to the accelerated compositor
https://bugs.webkit.org/show_bug.cgi?id=41243

Attachment 59841: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=59841&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebGraphicsContext3D.h:116
 +	virtual unsigned int getPlatformTextureId() = 0;
nit: "unsigned int" -> "unsigned" in webkit style

WebKit/chromium/src/GraphicsContext3D.cpp:363
 +	if (!webContext->initialize(webAttributes, webView)) {
instead of initializing a WebGraphicsContext3D with a WebView, we
should instead ask the WebViewClient to create a WebGraphicsContext3D
for us.  things that you request from a WebKitClient should not be
WebView or WebFrame dependent.

looks fine otherwise.