[webkit-reviews] review granted: [Bug 41088] [Qt] support dumpChildFrameScrollPositions : [Attachment 59546] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 28 06:46:41 PDT 2010
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 41088: [Qt] support dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=41088
Attachment 59546: Patch
https://bugs.webkit.org/attachment.cgi?id=59546&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:678
+ QList<QWebFrame *> children = frame->childFrames();
No space needed before *
WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:691
+ QWebFrame* parent = qobject_cast<QWebFrame *>(frame->parent());
Neither here
More information about the webkit-reviews
mailing list