[webkit-reviews] review granted: [Bug 41266] [Qt] dump bf history of child windows : [Attachment 59862] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 41266: [Qt] dump bf history of child windows
https://bugs.webkit.org/show_bug.cgi?id=41266

Attachment 59862: Patch
https://bugs.webkit.org/attachment.cgi?id=59862&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:804
 +	    if (m_controller->shouldDumpBackForwardList()) {


WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807
 +		  fprintf(stdout, "%s",
dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).to
Utf8().constData());
indentation seems wrong here, please fix before committing

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807
 +		  fprintf(stdout, "%s",
dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).to
Utf8().constData());
I guess this would look less confusing, if you added the cast to a separate
line.