[webkit-reviews] review granted: [Bug 41253] [GTK] Add support for GTK+3 : [Attachment 59842] gtk3.diff
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 28 05:32:22 PDT 2010
Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 41253: [GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253
Attachment 59842: gtk3.diff
https://bugs.webkit.org/attachment.cgi?id=59842&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
439 JSCORE_GIRSOURCES += JSCore- at WEBKITGTK_API_VERSION@.gir
We should split libjscore later this cycle, too, btw. That would make
distributions happy.
440 WEBKIT_GIRSOURCES += WebKit- at WEBKITGTK_API_VERSION@.gir
I think we should also rename the gir/typelib files to WebKitGtk, for
consistency.
8 Adapt build system to 3.x support.
s/to/for/? =)
All looks good to me otherwise.
More information about the webkit-reviews
mailing list