[webkit-reviews] review granted: [Bug 41153] rebaseline-chromium-webkit-tests should add or remove files to local git repository : [Attachment 59869] patch v2

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 41153: rebaseline-chromium-webkit-tests should add or remove files to local
git repository
https://bugs.webkit.org/show_bug.cgi?id=41153

Attachment 59869: patch v2
https://bugs.webkit.org/attachment.cgi?id=59869&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKitTools/Scripts/webkitpy/common/checkout/scm.py:528
 +	    # path is assumed to be cwd relative?
This is a general problem with this class and part of why we recently add a
"run" method which knows how to set the CWD to the webkit root when necessary.

WebKitTools/Scripts/webkitpy/common/checkout/scm.py:575
 +	    return self.run_status_and_extract_filenames(self.status_command(),
self._status_regexp("D"))
We should probably add a new abstraction for this soon. 
self._files_matching_status("D") or similar.  Not needed for this patch.

WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py:391
 +	def _shared_test_add_recursively(self):
Eventually I need to figure out a better way to do these "shared" tests.

WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py:650
 +	    self.scm.propset("svn:mime-type", "application/octet-stream",
filepath)
The test would be slightly better if it used an impossible mimetype, so that we
knew there was no way SVN would autodetect to that particular type.

WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:4
85
 +			_log.warn('  Failed to add baselines to SVN.')
Not quite true anymore. :)

This is a FANTASTIC step forward.  Thank you for doing this!