[webkit-reviews] review granted: [Bug 41265] Clean up some loose ends in HTML5 tree builder : [Attachment 59861] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 27 14:55:43 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41265: Clean up some loose ends in HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41265
Attachment 59861: Patch
https://bugs.webkit.org/attachment.cgi?id=59861&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/ChangeLog:17
+ - Originally I thought that comments had speciall processing in
the
special
WebCore/html/HTMLTreeBuilder.cpp:622
+
currentElement()->addChild(HTMLElementFactory::createHTMLElement(QualifiedName(
nullAtom, token.name(), xhtmlNamespaceURI), m_document, 0));
Seems we should wrap this in a function. One which just takes the
token.name(). createHTMLElement()? addHTMLElement()?
More information about the webkit-reviews
mailing list