[webkit-reviews] review requested: [Bug 40273] Canvas: "currentColor" should inherit the canvas element's color : [Attachment 59848] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 27 02:50:26 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 40273: Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273

Attachment 59848: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=59848&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
The first revision wasn't covering all API's. This one does, including
CanvasGradient::addColorStop() and WebKit's non-standard CRC2D methods.

I've also included a layout test which covers the various code paths.


More information about the webkit-reviews mailing list