[webkit-reviews] review granted: [Bug 41247] Web Inspector: ScripsPanel.prototype.editScriptSource uses old addBreakpoint signature. : [Attachment 59830] [PATCH] Style fixed.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 26 05:51:13 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 41247: Web Inspector: ScripsPanel.prototype.editScriptSource uses old
addBreakpoint signature.
https://bugs.webkit.org/show_bug.cgi?id=41247
Attachment 59830: [PATCH] Style fixed.
https://bugs.webkit.org/attachment.cgi?id=59830&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/front-end/BreakpointManager.js:151
+ this._breakpointManager._saveBreakpointOnBackend(this);
These methods should not be called after the breakpoint has been removed. Can
you fix the call sites instead?
We need a test for this.
More information about the webkit-reviews
mailing list