[webkit-reviews] review requested: [Bug 40607] Implement the sync DB API in workers : [Attachment 59831] patch #1: implement DatabaseSync::openDatabaseSync()

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 40607: Implement the sync DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=40607

Attachment 59831: patch #1: implement DatabaseSync::openDatabaseSync()
https://bugs.webkit.org/attachment.cgi?id=59831&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Same patch, with minor changes:
1. Made ScriptExecutionContext aware of sync DBs, because we need a place to
close them before the destructor runs (calling
DatabaseTracker::removeOpenDatabase() in the destructor leads to weird things
in Chromium).
2. Because of #1, moved 2 sync DB-specific lines from the loop in
ScriptExecutionContext::stopDatabases() to Database::stop().
3. Commented out some test cases in the layout test, because they fail in V8.
The failure happens because unlike JSC, v8 suppresses the errors in toString().
I'm investigating why this is so, and what can be done to make JSC and V8
behave the same way.