[webkit-reviews] review granted: [Bug 41188] Animations should not require from/to keyframes : [Attachment 59809] updated patch with refactored ::styleForKeyframe
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 25 16:50:21 PDT 2010
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 41188: Animations should not require from/to keyframes
https://bugs.webkit.org/show_bug.cgi?id=41188
Attachment 59809: updated patch with refactored ::styleForKeyframe
https://bugs.webkit.org/attachment.cgi?id=59809&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> + RefPtr<RenderStyle> keyframeStyle;
>
> // Construct and populate the style for each keyframe
> for (unsigned i = 0; i < rule->length(); ++i) {
You should declare keyframeStyle inside the loop.
> + keyframeStyle.release();
> +
Extra blank line here.
r=me
More information about the webkit-reviews
mailing list