[webkit-reviews] review denied: [Bug 41188] Animations should not require from/to keyframes : [Attachment 59806] updated patch with review fixes, new testcase for HW animations, and a manual test

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Dean Jackson
<dino at apple.com>'s request for review:
Bug 41188: Animations should not require from/to keyframes
https://bugs.webkit.org/show_bug.cgi?id=41188

Attachment 59806: updated patch with review fixes, new testcase for HW
animations, and a manual test
https://bugs.webkit.org/attachment.cgi?id=59806&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
WebCore/ChangeLog:12
 +	    Tests: animations/fill-mode-missing-from-to-keyframes.html
Wrong test listed here, and transform test is missing.

I'd prefer that CSSStyleSelector::generateKeyframeStyle() not do the insertion
into the KeyframeList. I think it should just return a RenderStyle. You could
make another method that sets the RenderStyle for the appropriate keys.

The manual test should say what is being tested, and reference this bug.

r- to refactor use of generateKeyframeStyle().