[webkit-reviews] review requested: [Bug 40627] Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) : [Attachment 59800] [PATCH] Part 4 - Client Notification when the Quota is Reached (needs part 3)

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 40627: Limit ApplicationCache Total and Per-Origin Storage Capacity
(Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627

Attachment 59800: [PATCH] Part 4 - Client Notification when the Quota is
Reached (needs part 3)
https://bugs.webkit.org/attachment.cgi?id=59800&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>

Client notifications. I ran into an issue with WebSecurityOrigin.
WebSecurityOrigin is
used in a private interface (WebUIDelegatePrivate.h). It also has Database
Quota
management baked in. And finally it uses (unsigned long long) types. The
problems are:

  - (unsigned long long) makes sense for a quota, but they are stored in a
SQLite DB as
    (long long) anyways. So, there is a downcast. I've changed the interface in

    WebSecurityOrigin to prevent any clients from providing too high a value,
but
    Database's still have a potential downcast issue.
    
  - To not break the interface, I kept (WebSecurityOrigin*) as the type. And I
give
    generic implementations of the quota management functions (usage, quota,
setQuota)
    and instead rely on subclasses to handle it correctly. There are now
Database
    and ApplicationCache subclasses which handle each of their respective
quotas.

I think I'll stop here. Part 5 would be adding a test to make sure it all
works, but
I don't want to go that far unless I've got an okay on some of the patches
before!