[webkit-reviews] review granted: [Bug 41171] JSC bindings for Image Resizer API : [Attachment 59782] JSC bindings
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 25 13:59:18 PDT 2010
David Levin <levin at chromium.org> has granted Sterling Swigart
<sswigart at google.com>'s request for review:
Bug 41171: JSC bindings for Image Resizer API
https://bugs.webkit.org/show_bug.cgi?id=41171
Attachment 59782: JSC bindings
https://bugs.webkit.org/attachment.cgi?id=59782&action=review
------- Additional Comments from David Levin <levin at chromium.org>
One more change that I can do on landing.
I think I must have miscommunicated about what would be ideal here.
WebCore/html/AsyncImageResizer.cpp:73
+ m_callbackInfo = 0;
I think this leaks the pointer that was in m_callbackInfo. The logic should be
reversed in this area.
And the final if should be
if (m_callbackInfo) {
resizeError();
delete m_callbackInfo;
}
More information about the webkit-reviews
mailing list