[webkit-reviews] review denied: [Bug 41223] [chromium] Send unhandled events to Node's default handler : [Attachment 59788] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 25 13:45:13 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 41223: [chromium] Send unhandled events to Node's default handler
https://bugs.webkit.org/show_bug.cgi?id=41223
Attachment 59788: Patch
https://bugs.webkit.org/attachment.cgi?id=59788&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebPluginContainerImpl.cpp:171
> + // FIXME: it would be cleaner if widge::handleEvent returned
true/false and
nit: "widge" -> Widget
WebKit/chromium/src/WebPluginContainerImpl.cpp:174
+ m_element->Node::defaultEventHandler(event);
nit: indent by 4 spaces
More information about the webkit-reviews
mailing list