[webkit-reviews] review requested: [Bug 40197] Enhance the hit testing to take a rectangle instead of a point : [Attachment 59789] patch v1 - feature + tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 25 13:15:22 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 40197: Enhance the hit testing to take a rectangle instead of a point
https://bugs.webkit.org/show_bug.cgi?id=40197

Attachment 59789: patch v1 - feature + tests
https://bugs.webkit.org/attachment.cgi?id=59789&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
This new patch (named 'v1') comprises previous work done by Grace (see obsolete
patches), as well as a testing infrastructure for the rect-based hit test
feature.

As ways to expose the functionality, the patch:

- adds a nodesFromRect method to the Document class, exposing the funcionality
to the DOM. Method returns a NodeList with all nodes that intersect the given
hit-tested area.
- extends hitTestResultAtPoint method of the EventHandler with an extra
'padding' parameter, defaulting to IntSize(0,0). The rect-based hit test is
performed when a non-zero padding is passed in.

If padding is IntSize(0,0) or omitted, point based HitTest is performed.


More information about the webkit-reviews mailing list