[webkit-reviews] review granted: [Bug 41197] Split DocumentParser::write into separate append and insert calls : [Attachment 59749] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41197: Split DocumentParser::write into separate append and insert calls
https://bugs.webkit.org/show_bug.cgi?id=41197

Attachment 59749: Patch
https://bugs.webkit.org/attachment.cgi?id=59749&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I wonder if we should have another method for the "I'm giving you all the data
at once" use case.  It seems a bit odd to call "insert" for that use just
because you want it to be synchronous.	There are other side effects too, like
not using the pre-load scanner.  Do we want to use the preload scanner for FTP
directory listings?  (Probably not for XMLHttpRequest.)  Maybe we really should
have an options argument?  It's unclear to me what the most elegant solution
is.

WebCore/html/HTMLDocumentParser.cpp:216
 +  void HTMLDocumentParser::insert(const SegmentedString& source)
Has tony's patch to exclude line numbers not landed?  That should be here too.