[webkit-reviews] review granted: [Bug 41188] Animations should not require from/to keyframes : [Attachment 59760] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 25 07:54:27 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 41188: Animations should not require from/to keyframes
https://bugs.webkit.org/show_bug.cgi?id=41188

Attachment 59760: patch
https://bugs.webkit.org/attachment.cgi?id=59760&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
WebCore/css/CSSStyleSelector.cpp:1466
 +	if (initialListSize > 0 && (list.endKeyframes()-1)->key() != 1) {
Need spaces around the minus here.

LayoutTests/ChangeLog:8
 +	    * animations/fill-mode-missing-from-to-keyframes-expected.txt:
Added.
 +	    * animations/fill-mode-missing-from-to-keyframes.html: Added.

Did you mean to include these?WebCore/css/CSSStyleSelector.h:115
 +	    void generateKeyframeStyle(const RenderStyle*, const
WebKitCSSKeyframeRule*, KeyframeList&);

This should be private.

Does this patch do the right thing if there's a transition running on the
property that the animation is going to affect, and the 0% keyframe is missing?


More information about the webkit-reviews mailing list