[webkit-reviews] review granted: [Bug 41150] Improve default value handling of page format properties : [Attachment 59739] Addressed review comments.

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 41150: Improve default value handling of page format properties
https://bugs.webkit.org/show_bug.cgi?id=41150

Attachment 59739: Addressed review comments.
https://bugs.webkit.org/attachment.cgi?id=59739&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good. A few nitpicks:

WebCore/css/CSSStyleSelector.cpp:5517
 +	m_style->setPageSizeType(PAGE_SIZE_UNDEFINED);
The standard way would be to define RenderStyle::resetPageSizeType

WebCore/dom/Document.cpp:1518
 +	case PAGE_SIZE_UNDEFINED:
Can this happen? If not, we might want ASSERT_NOT_REACHED. Otherwise, we might
not need PAGE_SIZE_UNDEFINED and we can just use PAGE_SIZE_AUTO as the initial
value of pageSizeType.