[webkit-reviews] review granted: [Bug 41184] Sketch out InHeadMode for tree builder : [Attachment 59711] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 24 22:22:31 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41184: Sketch out InHeadMode for tree builder
https://bugs.webkit.org/show_bug.cgi?id=41184
Attachment 59711: Patch
https://bugs.webkit.org/attachment.cgi?id=59711&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTMLTreeBuilder.cpp:358
+ // FIXME: Atomize "command".
Silly fixme. DEFINE_LOCAL(AtomicString, commandAtom, "command") is all you
need. :)
Yeah, this is going to be the wrong design. We're going to want to switch
based on tag and then on state, instead of how the spec is written which is
state then tag.WebCore/html/HTMLTreeBuilder.cpp:400
+ break;
This break seems silly.
More information about the webkit-reviews
mailing list