[webkit-reviews] review denied: [Bug 41100] add ENABLE_DIRECTORY_UPLOAD build support : [Attachment 59561] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied John Gregg <johnnyg at google.com>'s
request for review:
Bug 41100: add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

Attachment 59561: Patch
https://bugs.webkit.org/attachment.cgi?id=59561&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>

> checking whether to build gtk-doc documentation... no
> checking for gtkdoc-check... /usr/bin/gtkdoc-check
> ../../configure: line 21510: syntax error near unexpected token `('
> ../../configure: line 21510: `    as_echo_body='eval expr "X$1" :
"X\\(.*\\)"''
> Failed to setup build environment using 'autotools'!

I don't know the reason, but I confirmed this error of GTK was caused by your
changes for config.ac and WebCore/GNUmakefile.am.

WebKit/chromium/features.gypi:48
 +	    'ENABLE_DIRECTORY_UPLOAD=0',
I recommend enable ENABLE_DIRECTORY_UPLOAD for this file because
 - We can confirm build by buildbots
 - Changing features.gypi later is hard because of Bug#38926.