[webkit-reviews] review requested: [Bug 41178] Timed refresh in subframes isn't stopped when going into b/f cache : [Attachment 59706] proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 41178: Timed refresh in subframes isn't stopped when going into b/f cache
https://bugs.webkit.org/show_bug.cgi?id=41178

Attachment 59706: proposed fix
https://bugs.webkit.org/attachment.cgi?id=59706&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> Don't we restore redirect timers for the main frame when restoring from the
page cache?

We don't. Pages that come back from page cache are almost dead, see
semi-related bug 34679.

> Maybe we should to create a new TLD in LayoutTests 'slow' for this type of
test?

I don't think it would be helpful. The reason to have multiple directories is
that one can run only a subset of tests pertinent to the code area while
iteratively developing a patch (e.g., I've been running fast/history,
fast/events and fast/frames for this patch).

And this test isn't the slowest that we have!