[webkit-reviews] review granted: [Bug 41136] Add RawDataDocumentParser to get rid of a bunch of copy/paste code in DocumentParser subclasses : [Attachment 59622] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 24 14:43:38 PDT 2010
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41136: Add RawDataDocumentParser to get rid of a bunch of copy/paste code
in DocumentParser subclasses
https://bugs.webkit.org/show_bug.cgi?id=41136
Attachment 59622: Patch
https://bugs.webkit.org/attachment.cgi?id=59622&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch appears to be almost entirely minus lines.
WebCore/dom/RawDataDocumentParser.h:57
+ ASSERT_NOT_REACHED();
This used to be notImplemented, right?
More information about the webkit-reviews
mailing list