[webkit-reviews] review granted: [Bug 40635] Full screen video in Safari exits full-screen if you switch to another app : [Attachment 59289] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 24 13:13:29 PDT 2010
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 40635: Full screen video in Safari exits full-screen if you switch to
another app
https://bugs.webkit.org/show_bug.cgi?id=40635
Attachment 59289: Patch
https://bugs.webkit.org/attachment.cgi?id=59289&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
WebKit/mac/WebView/WebVideoFullscreenController.mm:196
+ - (void)applicationDidResignActive:(NSNotification*)notification
Should have a space between type and *
WebKit/mac/WebView/WebVideoFullscreenController.mm:200
+ NSWindow* fullscreenWindow = [self fullscreenWindow];
Same here
More information about the webkit-reviews
mailing list