[webkit-reviews] review denied: [Bug 40835] Adds support for throwing behavior of SerializedScriptValue to be specified in the IDL. : [Attachment 59405] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 40835: Adds support for throwing behavior of SerializedScriptValue to be
specified in the IDL.
https://bugs.webkit.org/show_bug.cgi?id=40835

Attachment 59405: Patch
https://bugs.webkit.org/attachment.cgi?id=59405&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/bindings/js/SerializedScriptValue.cpp:987
 +	PassRefPtr<SerializedScriptValue> serializedValue = new
SerializedScriptValue(SerializedScriptValueData::serialize(exec, value));
RefPtr not PassRefPtr

WebCore/bindings/js/SerializedScriptValue.cpp:994
 +	return serializedValue;
.release() here.

WebCore/bindings/js/SerializedScriptValue.cpp:981
 +	PassRefPtr<SerializedScriptValue> serializedValue =
SerializedScriptValue::create(exec, value, &ec);
Don't you need to set the dom exception here as well?
Also don't use PassRefPtr within a function.

WebCore/bindings/scripts/CodeGeneratorJS.pm:1719
 +					push(@implContent, "	podImp = " .
JSValueToNative($attribute->signature, "value", 0) . ";\n");
Use booleans.

WebCore/bindings/scripts/CodeGeneratorJS.pm:1721
 +					push(@implContent, "   
podImp.set$implSetterFunctionName(" . JSValueToNative($attribute->signature,
"value", 0) . ");\n");
ditto (and elsewhere)

LayoutTests/storage/indexeddb/script-tests/idb-add-serialized-script-value.js:1

 +  description("Test IndexedDB's openCursor.");
Update the description.

LayoutTests/storage/indexeddb/resources/shared.js:52
 +	testFailed("Success function called unexpectedly: (" + event.code + ")
" + event.message);
There will be no code/message.

LayoutTests/fast/loader/stateobjects/initpopstateevent-expected.txt:5
 +  PASS serialized script value threw an exception due to a cycle.
Put a message in the beginning saying it'll print "COMPLETE" when done and then
add code to do that.