[webkit-reviews] review denied: [Bug 41094] Web Inspector: Inspector cleanup + better DevTools alignment with Inspector. : [Attachment 59554] [PATCH] Same with InspectorClientImpl files actually removed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 24 01:43:57 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 41094: Web Inspector: Inspector cleanup + better DevTools alignment with
Inspector.
https://bugs.webkit.org/show_bug.cgi?id=41094

Attachment 59554: [PATCH] Same with InspectorClientImpl files actually removed.
https://bugs.webkit.org/attachment.cgi?id=59554&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebKit/chromium/src/WebDevToolsAgentImpl.cpp:486
 +	if (!agent->m_apuAgentEnabled)
At first check if there is ApuAgent and dispatch the message just to it.

WebKit/chromium/src/WebViewImpl.cpp: 
 +  void WebViewImpl::setDevToolsAgent(WebDevToolsAgent* devToolsAgent)
It is likely to break layout tests. Make sure they are fine.

WebKit/chromium/src/js/InjectDispatch.js: 
 +  function close() {
Pleas make sure tests pass.


More information about the webkit-reviews mailing list