[webkit-reviews] review granted: [Bug 41117] Move Document* down onto DocumentParser, since every DocumentParser needs one. : [Attachment 59613] Address Darin and Adam's feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 23 23:10:41 PDT 2010


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41117: Move Document* down onto DocumentParser, since every DocumentParser
needs one.
https://bugs.webkit.org/show_bug.cgi?id=41117

Attachment 59613: Address Darin and Adam's feedback
https://bugs.webkit.org/attachment.cgi?id=59613&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/dom/DocumentParser.h:27
 +  // If move DocumentParser() to a DocumentParser.cpp, this include can go
away.
Darin asked you to remove this comment.

WebCore/dom/XMLDocumentParserLibxml2.cpp: 
 +	    m_doc->ref();
Nice.


More information about the webkit-reviews mailing list