[webkit-reviews] review requested: [Bug 41092] Index validation caches buffer size information too aggressively : [Attachment 59605] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 23 19:46:48 PDT 2010


Kenneth Russell <kbr at google.com> has asked  for review:
Bug 41092: Index validation caches buffer size information too aggressively
https://bugs.webkit.org/show_bug.cgi?id=41092

Attachment 59605: Patch
https://bugs.webkit.org/attachment.cgi?id=59605&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
>From the ChangeLog:

Do not cache the buffer size during vertexAttribPointer, only the attributes
used to compute the number of required elements. Compute the number of valid
elements each time based on the latched buffer.

Tested in Safari and Chromium on Mac OS X in both debug and release mode to
ensure no performance regressions.


More information about the webkit-reviews mailing list