[webkit-reviews] review granted: [Bug 41117] Move Document* down onto DocumentParser, since every DocumentParser needs one. : [Attachment 59589] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41117: Move Document* down onto DocumentParser, since every DocumentParser
needs one.
https://bugs.webkit.org/show_bug.cgi?id=41117

Attachment 59589: Patch
https://bugs.webkit.org/attachment.cgi?id=59589&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/dom/DocumentParser.h:32
 +	class Document;
You should fix the indent here while you're mucking with things.

WebCore/dom/XMLDocumentParserLibxml2.cpp:525
 +  XMLDocumentParser::XMLDocumentParser(Document* _doc, FrameView* _view)
Can you fix these parameter names too?

WebCore/dom/XMLDocumentParserLibxml2.cpp:578
 +	// FIXME: The Document owns the Parser, we shouldn't need to ref the
Document.
Please remove this in a follow-up patch.

WebCore/loader/ImageDocument.cpp:97
 +	    return static_cast<ImageDocument*>(document());
Yuck.

WebCore/loader/PluginDocument.cpp:54
 +	}
Missing blank line after this line.

WebCore/loader/SinkDocument.cpp:35
 +	SinkDocumentParser(Document* document) : DocumentParser(document) { }
Please split into multiple lines for consistency.