[webkit-reviews] review denied: [Bug 41106] [chromium] Allow composited layers to own their textures and specify how they get rendered : [Attachment 59570] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 41106: [chromium] Allow composited layers to own their textures and specify
how they get rendered
https://bugs.webkit.org/show_bug.cgi?id=41106

Attachment 59570: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=59570&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Looks good to me.  Just a couple nits:

WebCore/platform/graphics/chromium/LayerChromium.cpp:399
 +  unsigned int WebGLLayerChromium::m_shaderProgramId = 0;
nit: webkit style is to just use "unsigned" instead of "unsigned int"

WebCore/platform/graphics/chromium/LayerChromium.h:257
 +  class ImageLayerChromium : public LayerChromium {
style-nit: one class per file is the rule.  would you be okay splitting
these out into their own files?