[webkit-reviews] review denied: [Bug 40319] Implement format conversions in texImage2D and texSubImage2D taking HTML data : [Attachment 59449] Revised patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Kenneth Russell
<kbr at google.com>'s request for review:
Bug 40319: Implement format conversions in texImage2D and texSubImage2D taking
HTML data
https://bugs.webkit.org/show_bug.cgi?id=40319

Attachment 59449: Revised patch
https://bugs.webkit.org/attachment.cgi?id=59449&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Some comments from over-the-shoulder review:

WebCore/platform/graphics/GraphicsContext3D.cpp:459
 +	    if (destinationFormat == RGBA && alphaOp == kAlphaDoNothing) {
must check sourceDataFormat == kSourceFormatRGBA8!

WebCore/platform/graphics/GraphicsContext3D.cpp:479
 +		switch (alphaOp) {
add case for kAlphaDoNothing in case sourceDataFormat is not RGBA8

LayoutTests/fast/canvas/webgl/tex-image-with-format-and-type.html:97
 +		    useImageData: (useImageData ? true : false),
Can just do !!useImageData