[webkit-reviews] review requested: [Bug 40607] Implement the sync DB API in workers : [Attachment 59556] patch #1: implement DatabaseSync::openDatabaseSync()

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 40607: Implement the sync DB API in workers
https://bugs.webkit.org/show_bug.cgi?id=40607

Attachment 59556: patch #1: implement DatabaseSync::openDatabaseSync()
https://bugs.webkit.org/attachment.cgi?id=59556&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
(In reply to comment #24)
> > void DatabaseSync::markAsDeletedAndClose()
> > {
> >	// FIXME: we probably need to do something else in here other than
calling closeImmediately().
> >	closeImmediately();
> > }
> > 
> > void DatabaseSync::closeImmediately()
> > {
> >	// FIXME: probably need to do more things in here
> >	closeDatabase();
> >	DatabaseTracker::tracker().removeOpenDatabase(this);
> > }
> 
> These methods are not called on the ScriptExecutionContext's thread, but the
closeDatabase() method uses the sqlite3 database handle. That looks like a
threading violation that needs to be resolved.

fixed.