[webkit-reviews] review requested: [Bug 9197] CSS3: Borders with border-radius and double, groove, or ridge styles should look better : [Attachment 59552] Patch the won't break other platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 23 12:42:44 PDT 2010


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 9197: CSS3: Borders with border-radius and double, groove, or ridge styles
should look better
https://bugs.webkit.org/show_bug.cgi?id=9197

Attachment 59552: Patch the won't break other platforms
https://bugs.webkit.org/attachment.cgi?id=59552&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
After talking with Darin and Sam, I decided to keep around the old version of
RenderBoxModelObject::paintBorder() and RenderObject::drawArcForBoxSide() for
non-CG platforms. After I get an r+, I will file bugs for the other platforms
to implement GraphicsContext::clipConvexPolygon() and email WebKit dev about
it. But in the meantime, non-CG platforms will just have our same old
border-radius support, and they can switch to the new hotness once they
implement that one function.

Just realized I should update the Changlog to reflect this. Will do that now,
but I won't bother posting a new patch for it unless someone really wants me
to.


More information about the webkit-reviews mailing list