[webkit-reviews] review requested: [Bug 30896] [Gtk] Implement atk_table_get_column_header : [Attachment 59528] Full patch proposal (with unit test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 23 10:27:22 PDT 2010


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 30896: [Gtk] Implement atk_table_get_column_header
https://bugs.webkit.org/show_bug.cgi?id=30896

Attachment 59528: Full patch proposal (with unit test)
https://bugs.webkit.org/attachment.cgi?id=59528&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Hi, after spending most of the time struggling with another bug found while
working on this one [*], now that one is fixed I was finally able to finish
Joanmarie's work by adding a new unit test in testatk, as well as fixing some
small issues in get_row_header() to keep it coherent with get_column_header(),
and make it work well.

Hence, attaching now the patch that fixes this stuff. Hope you like it.

[*] https://bugs.freedesktop.org/show_bug.cgi?id=28659


More information about the webkit-reviews mailing list