[webkit-reviews] review requested: [Bug 37939] Fix PluginViewNone.cpp compilation for ports that also compile PluginView.cpp : [Attachment 59521] Patch w/updated comment and rebased to latest trunk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 23 09:34:35 PDT 2010


Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 37939: Fix PluginViewNone.cpp compilation for ports that also compile
PluginView.cpp
https://bugs.webkit.org/show_bug.cgi?id=37939

Attachment 59521: Patch w/updated comment and rebased to latest trunk
https://bugs.webkit.org/attachment.cgi?id=59521&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
The comment is a bit wordy still, but I think it's much clearer and easy to
understand. I also moved those three methods to the bottom of the file so that
there is a clear 'place' in the file for these methods to go, which will
hopefully help keep things cleanly separated.


More information about the webkit-reviews mailing list