[webkit-reviews] review denied: [Bug 40352] [Qt] instance objects created for QObjects are somtimes GC'd : [Attachment 59429] Rediff against trunk

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40352: [Qt] instance objects created for QObjects are somtimes GC'd
https://bugs.webkit.org/show_bug.cgi?id=40352

Attachment 59429: Rediff against trunk
https://bugs.webkit.org/attachment.cgi?id=59429&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
WebCore/ChangeLog:13
 +	    No new tests. (OOPS!)
If there are no new tests, then please remove this line.

However there are some tests for this code in WebKit/qt/tests/qwebframe (don't
ask :). Could you add an auto-tests for this case there?

WebCore/bridge/qt/qt_instance.cpp:202
 +	    } else if ( m_object ) {
Please remove the spaces around m_object.

WebCore/bridge/qt/qt_instance.cpp:212
 +	    if ( mark ) {
Ditto.