[webkit-reviews] review requested: [Bug 32530] QtWebkit creates an unnecessary deep copy of images when canvas drawing is done : [Attachment 59513] New proposed patch

[bugzilla-daemon at webkit.org]

Samuel Rødal <samuel.rodal at nokia.com> has asked  for review:
Bug 32530: QtWebkit creates an unnecessary deep copy of images when canvas
drawing is done
https://bugs.webkit.org/show_bug.cgi?id=32530

Attachment 59513: New proposed patch
https://bugs.webkit.org/attachment.cgi?id=59513&action=review

------- Additional Comments from Samuel Rødal <samuel.rodal at nokia.com>
Simply making m_pixmap a reference solved the problem of deep copying as far as
I can see. In addition a check can be made to make sure we don't draw the
canvas onto itself without deep copying. I don't see the need to create a new
BufferedImage class when StillImage is only used for this single purpose.