[webkit-reviews] review granted: [Bug 40847] [GTK] Fix DOM event dispatch : [Attachment 59136] eventlisteres.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 23 06:25:26 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 40847: [GTK] Fix DOM event dispatch
https://bugs.webkit.org/show_bug.cgi?id=40847

Attachment 59136: eventlisteres.diff
https://bugs.webkit.org/attachment.cgi?id=59136&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
This looks very good to me. The only conceptual problem I have is with the
property - I don't think we should expose a core object in public API (which a
property ends up being). Having said that, I understand it would be difficult
to deal with this in another way, and approve of the method. Time for GObject
to grow private/protected properties? =)


More information about the webkit-reviews mailing list