[webkit-reviews] review denied: [Bug 40980] Web Inspector: null is not properly handled when evaluated in console (V8 only) : [Attachment 59497] patch (fixed abbreviation, always use toString for all functions)

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 40980: Web Inspector: null is not properly handled when evaluated in
console (V8 only)
https://bugs.webkit.org/show_bug.cgi?id=40980

Attachment 59497: patch (fixed abbreviation, always use toString for all
functions)
https://bugs.webkit.org/attachment.cgi?id=59497&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/InjectedScript.js:604
 +		objectText = /.*/.exec(obj)[0].replace(/ +$/g, "");
did you mean exec(objectText) here?

LayoutTests/inspector/console-tests-expected.txt:37
 +  console-tests.html:22null console-message console-js-source
console-log-level
I would expect to see console-formatted-null in the list of styles.

LayoutTests/platform/chromium/inspector/console-tests-expected.txt:1
 +  CONSOLE MESSAGE: line 9: log
Given that there is a handful of mismatches wrt WebKit, I would extract them
into separate test so that we could reuse most of the standard expectations.