[webkit-reviews] review granted: [Bug 41056] [chromium] Make page format data methods accessible from Chromium : [Attachment 59498] Make page format data methods accessible from Chromium
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 23 03:16:55 PDT 2010
Shinichiro Hamaji <hamaji at chromium.org> has granted Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 41056: [chromium] Make page format data methods accessible from Chromium
https://bugs.webkit.org/show_bug.cgi?id=41056
Attachment 59498: Make page format data methods accessible from Chromium
https://bugs.webkit.org/attachment.cgi?id=59498&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good, except for a nitpick in your comment.
WebKit/chromium/public/WebFrame.h:411
+ // Returns the page area rectangle in pixels, assuming 96 dpi.
I'd say pixels per inch instead of DPI. DPI can be a confusing as
points-per-inch is different from pixels-per-inch.
More information about the webkit-reviews
mailing list