[webkit-reviews] review denied: [Bug 40872] experimental directory upload : [Attachment 59269] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied John Gregg <johnnyg at google.com>'s
request for review:
Bug 40872: experimental directory upload
https://bugs.webkit.org/show_bug.cgi?id=40872

Attachment 59269: Patch
https://bugs.webkit.org/attachment.cgi?id=59269&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>

We need more preparation to introduce new feature flag.
https://bugs.webkit.org/show_bug.cgi?id=40878 is a good example.

WebCore/html/HTMLInputElement.cpp:1975
 +		if (!paths[i].startsWith(rootPath)) {
Do we accept multiple directories?
If so and 'paths' contains the followings, full path names are exposed, right?
  - C:/data/1.jpg
  - C:/data/2.jpg
  - E:/data/1.jpg


WebCore/html/HTMLInputElement.cpp:1977
 +		    i = 0;
Why go back to 0?


WebCore/html/HTMLInputElement.h:190
 +	bool directory() const;
Do you need directory() and setDirectory()?  If you don't use them in C++ code,
we can remove them.