[webkit-reviews] review requested: [Bug 9197] CSS3: Borders with border-radius and double, groove, or ridge styles should look better : [Attachment 59473] New version of the patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 9197: CSS3: Borders with border-radius and double, groove, or ridge styles
should look better
https://bugs.webkit.org/show_bug.cgi?id=9197

Attachment 59473: New version of the patch
https://bugs.webkit.org/attachment.cgi?id=59473&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here's a new version of the patch. Dashed and dotted border looks WAY better
now. I also fleshed out stubs in all of the different ports of GraphicsContext.
I should really fill these in because border-radius implementations on other
platforms will break without this function, but it is a little scary to right
them without configurations to compile and test. Hmm…any advice anyone? 

Other know problems:
-Double borders need a little tweaking. This will be easy to fix in a follow-up
patch. I added a FIXME to borderWillArcInnerEdge in RenderBoxModelObject.
-Dashed and dotted borders could be even better if we tried centering the dash
pattern. Added a FIXME for this too.
-The angle of border sides is a little off sometimes. Should be fix-able in a
follow-up patch.
-Need to add more tests. Dan't interactive test case has been invaluable in
working on this, and we need more representation in the layout tests. I would
like to do this in a follow-up patch as well.