[webkit-reviews] review requested: [Bug 41019] Canvas: Remember verified clean origins for drawImage() : [Attachment 59456] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 22 18:35:12 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 41019: Canvas: Remember verified clean origins for drawImage()
https://bugs.webkit.org/show_bug.cgi?id=41019

Attachment 59456: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=59456&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
The origin of the canvas's underlying document will not change, so caching
verified URL's should be perfectly safe.

The KURL path is the common one, but it indeed makes more sense to cache the
Strings.

I've updated the patch to use HashSet<String>, thanks for the feedback.


More information about the webkit-reviews mailing list