[webkit-reviews] review requested: [Bug 40319] Implement format conversions in texImage2D and texSubImage2D taking HTML data : [Attachment 59448] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 40319: Implement format conversions in texImage2D and texSubImage2D taking
HTML data
https://bugs.webkit.org/show_bug.cgi?id=40319

Attachment 59448: Patch
https://bugs.webkit.org/attachment.cgi?id=59448&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
>From the ChangeLog:

Generalized code supporting premultiplication of alpha and vertical flip to
pack texture data into requested format and type. Handled incoming image data
of various formats, RGBA and BGRA in particular, both to reduce the number of
temporary copies during texture upload and to support premultiplying alpha for
the texImage2D and texSubImage2D entry points taking ArrayBufferView in a
subsequent bug. Added test case exercising all combinations of format/type
combinations, premultiplication of alpha, and Image/ImageData upload.
(Incorporated pnglib.js under fast/canvas/webgl/resources/ to be able to
generate Image elements programmatically.) Tested in Safari on Mac OS X and in
Chromium on Mac OS X, Windows and Linux.

Note to reviewers:

This is a large patch, but it is the smallest it can possibly be and still
implement a self-contained unit of functionality. The test case is exhaustive
and should exercise all of the new code paths, some of which have also been
verified manually by modifiying some existing WebGL demos.