[webkit-reviews] review granted: [Bug 41015] Change the encode functions to be specializations of a class template : [Attachment 59420] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 41015: Change the encode functions to be specializations of a class
template
https://bugs.webkit.org/show_bug.cgi?id=41015

Attachment 59420: Patch
https://bugs.webkit.org/attachment.cgi?id=59420&action=review

------- Additional Comments from mitz at webkit.org
> Index: WebKit/mac/ChangeLog
> ===================================================================
> --- WebKit/mac/ChangeLog	(revision 61630)
> +++ WebKit/mac/ChangeLog	(working copy)
> @@ -1,3 +1,12 @@
> +2010-06-22  Anders Carlsson	<andersca at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Change the encode functions to be specializations of a class
template
> +	   https://bugs.webkit.org/show_bug.cgi?id=41015
> +
> +	   * Plugins/Hosted/NetscapePluginHostProxy.h:
> +
>  2010-06-22  Anders Carlsson	<andersca at apple.com>
>  
>	   Reviewed by Sam Weinig.
> Index: WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h
> ===================================================================
> --- WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h	(revision
61627)
> +++ WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h	(working copy)
> @@ -84,11 +84,7 @@ private:
>      mach_port_t m_clientPort;
>      mach_port_t m_portSet;
>      
> -#ifdef USE_LIBDISPATCH
> -    dispatch_source_t m_clientPortSource;
> -#else
>      RetainPtr<CFRunLoopSourceRef> m_clientPortSource;
> -#endif
>      mach_port_t m_pluginHostPort;
>      RetainPtr<CFMachPortRef> m_deadNameNotificationPort;
>      

This doesn’t seem to be related. Please don’t land it as part of this patch.